Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amdvlk: 2020.Q3.6 -> 2020.Q4.1 #101241

Merged
merged 1 commit into from Oct 23, 2020
Merged

amdvlk: 2020.Q3.6 -> 2020.Q4.1 #101241

merged 1 commit into from Oct 23, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Oct 21, 2020

Motivation for this change

2020.Q4.1 was released: https://github.com/GPUOpen-Drivers/AMDVLK/releases/tag/v-2020.Q4.1

Things done
  • Tested vkcube and Dota 2
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from danieldk October 21, 2020 08:29
@danieldk
Copy link
Contributor

@Flakebi things are a bit busy around here. Will try to review tomorrow if nobody else gets to it.

danieldk
danieldk approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 101241 1

2 packages built:
  • amdvlk
  • driversi686Linux.amdvlk

@danieldk danieldk merged commit 1b90250 into NixOS:master Oct 23, 2020
@Flakebi Flakebi deleted the amdvlk branch October 23, 2020 07:16
@Flakebi
Copy link
Member Author

Flakebi commented Oct 23, 2020

Take your time, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flakebi @danieldk