Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.mkdx: init at 2020-10-12 #101232

Merged
merged 1 commit into from Dec 28, 2020
Merged

vimPlugins.mkdx: init at 2020-10-12 #101232

merged 1 commit into from Dec 28, 2020

Conversation

i077
Copy link
Contributor

@i077 i077 commented Oct 21, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@i077 i077 requested a review from jonringer as a code owner October 21, 2020 04:38
@ofborg ofborg bot requested review from jagajaga and jorsn October 21, 2020 05:03
@SuperSandro2000
Copy link
Member

Can you please remove the other update to resolve the merge conflict?

@i077
Copy link
Contributor Author

i077 commented Nov 27, 2020

Done, I dropped the other update commits and just left adding in the new plugin to the generated nix file.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101232 run on x86_64-linux 1

1 package built:
  • vimPlugins.mkdx

@SuperSandro2000 SuperSandro2000 merged commit 31c87fb into NixOS:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@jagajaga jagajaga Awaiting requested review from jagajaga

@jorsn jorsn Awaiting requested review from jorsn

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@i077 @SuperSandro2000