Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nuraft: init at 1.1.2 #101247

Merged
merged 2 commits into from Oct 29, 2020
Merged

nuraft: init at 1.1.2 #101247

merged 2 commits into from Oct 29, 2020

Conversation

wheelsandmetal
Copy link
Contributor

@wheelsandmetal wheelsandmetal commented Oct 21, 2020 •
edited

Motivation for this change

Add nuraft lib

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wheelsandmetal
Copy link
Contributor Author

Not sure who to set as maintainer

@AndersonTorres
Copy link
Member

@wheelsandmetal

If you are interested in maintain this package, you can add yourself at maintainers/maintainer-list.nix and add it to meta.maintainers list, or else just keep the list empty (basically "orphaning" the package).

Also, squash your commits to more meaningful messages. We don't pollut the commit log with small messages as "applying suggested changes" or "fix trailing whitespace". Just the original message "nuraft: init at 1.1.2" suffices.

@wheelsandmetal
Copy link
Contributor Author

@wheelsandmetal

If you are interested in maintain this package, you can add yourself at maintainers/maintainer-list.nix and add it to meta.maintainers list, or else just keep the list empty (basically "orphaning" the package).

Sure

Also, squash your commits to more meaningful messages. We don't pollut the commit log with small messages as "applying suggested changes" or "fix trailing whitespace". Just the original message "nuraft: init at 1.1.2" suffices.

ah didn't know, thanks!

AndersonTorres
AndersonTorres suggested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wheelsandmetal

Also, squash your commits to more meaningful messages. We don't pollut the commit log with small messages as "applying suggested changes" or "fix trailing whitespace". Just the original message "nuraft: init at 1.1.2" suffices.

ah didn't know, thanks!

Split the commits:

  • One for "add myself to maintainers"
  • The next one "nuraft: init at 1.1.2"

pkgs/development/libraries/nuraft/default.nix Outdated Show resolved Hide resolved
AndersonTorres
AndersonTorres approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, LGTBorg

@AndersonTorres AndersonTorres merged commit 75b92ef into NixOS:master Oct 29, 2020
@wheelsandmetal wheelsandmetal deleted the add-nuraft-lib branch October 29, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wheelsandmetal @AndersonTorres