Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: pull waveform generation functions out of DemoOscilloscope and make them global #313

Closed
azonenberg opened this issue Oct 21, 2020 · 0 comments
Labels
api API improvements cleanup Removing cruft

Comments

@azonenberg
Copy link
Collaborator

All of these functions should be moved to new files... let's call them TestWaveformGeneration.h/cpp.

As part of this refactoring, "noise_amplitude" should become a separate argument rather than a hard coded constant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API improvements cleanup Removing cruft
Projects
None yet
Development

No branches or pull requests

1 participant