Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt: 6.2.1 -> 7.0.3 #101251

Merged
merged 3 commits into from Nov 13, 2020
Merged

fmt: 6.2.1 -> 7.0.3 #101251

merged 3 commits into from Nov 13, 2020

Conversation

samuelgrf
Copy link
Member

@samuelgrf samuelgrf commented Oct 21, 2020 •
edited

Motivation for this change

pcsx2 master depends on fmt 7.0.3 and up, it'd be best to update fmt before pcsx2's next release, so we aren't stuck on an older version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jeroendehaas October 21, 2020 12:31
@samuelgrf

This comment has been minimized.

Sign in to view
@samuelgrf samuelgrf marked this pull request as draft October 21, 2020 20:59
@samuelgrf
Copy link
Member Author

Result of nixpkgs-review pr 101251 1

23 packages built:
  • adlplug
  • d-seams
  • fmt
  • fmt_6
  • kodi (xbmc)
  • kodi-gbm
  • kodi-wayland
  • kodiGBM
  • kodiPlain (xbmcPlain)
  • kodiPlainWayland
  • kodiPlugins.inputstream-adaptive
  • kodiPlugins.joystick
  • kodiPlugins.kodi-platform
  • kodiPlugins.pvr-hdhomerun
  • kodiPlugins.pvr-hts
  • kodiPlugins.pvr-iptvsimple
  • kodiPlugins.steam-controller
  • kodiPlugins.vfs-libarchive
  • kodiPlugins.vfs-sftp
  • mkvtoolnix
  • mkvtoolnix-cli
  • mpvScripts.convert
  • opnplug

@samuelgrf samuelgrf marked this pull request as ready for review October 23, 2020 14:13
@samuelgrf samuelgrf mentioned this pull request Nov 11, 2020
Merged
10 tasks
@samuelgrf
Copy link
Member Author

@Lassulus can you review this?

@Lassulus
Copy link
Member

Result of nixpkgs-review pr 101251 1

23 packages built:
  • adlplug
  • d-seams
  • fmt (fmt_7)
  • fmt_6
  • kodi
  • kodi-gbm
  • kodi-wayland
  • kodiGBM
  • kodiPlain (kodiPlugins.kodi)
  • kodiPlainWayland
  • kodiPlugins.inputstream-adaptive
  • kodiPlugins.joystick
  • kodiPlugins.kodi-platform
  • kodiPlugins.pvr-hdhomerun
  • kodiPlugins.pvr-hts
  • kodiPlugins.pvr-iptvsimple
  • kodiPlugins.steam-controller
  • kodiPlugins.vfs-libarchive
  • kodiPlugins.vfs-sftp
  • mkvtoolnix
  • mkvtoolnix-cli
  • mpvScripts.convert
  • opnplug

@Lassulus Lassulus merged commit 5c816b9 into NixOS:master Nov 13, 2020
@colemickens colemickens mentioned this pull request Nov 20, 2020
Closed
@samuelgrf samuelgrf deleted the update-fmt branch March 5, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeroendehaas jeroendehaas Awaiting requested review from jeroendehaas

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuelgrf @Lassulus