New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nanovna-saver: init at 0.3.7 #101244
nanovna-saver: init at 0.3.7 #101244
Conversation
dontWrapGApps = true; | ||
dontWrapQtApps = true; | ||
|
||
postFixup = '' | ||
wrapProgram $out/bin/NanoVNASaver \ | ||
"''${gappsWrapperArgs[@]}" \ | ||
"''${qtWrapperArgs[@]}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment why this is necessary? For me this is not logical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually thought the same. But without it, the executable doesn't start and fails with the dreaded qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
. I'm not sure how else this can be solved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. This is a very common pattern.
ffd5fbc
to
0bcd1b5
Compare
@zaninime please create a commit for every different package/expression you deem needed. In this particular case, a commit for scipy and another for nanovna-saver. It helps in case of future updates and cherry-picks. |
0bcd1b5
to
4f289c5
Compare
@AndersonTorres @SuperSandro2000 anything else that should be done here? I think I addressed all the issues raised so far. |
Just being a bit pedantic: a clearer commit message.
|
4f289c5
to
2a54c4f
Compare
@AndersonTorres fixed, the previous one was inspired by the message left on |
@zaninime Thanks! |
scipy_1_4 = self.scipy.overridePythonAttrs (oldAttrs: rec { | ||
version = "1.4.1"; | ||
src = oldAttrs.src.override { | ||
inherit version; | ||
sha256 = "0ndw7zyxd2dj37775mc75zm4fcyiipnqxclc45mkpxy8lvrvpqfy"; | ||
}; | ||
doCheck = false; | ||
disabled = !isPy3k; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Versioned attributes in python-packages.nix
are not allowed! You have to use packageOverrides
instead. I will have to remove nanovna-saver
as well if this is not rectified promptly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in #127910
Motivation for this change
Add package
nanovna-saver
. It depends on scipy 1.4, so I needed to add the dependency inpythonPackages
. I'm not sure if that needed a separate PR.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)