Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/dhcpcd: if disabled IPv6 don't solicit or accept IPv6 #101249

Merged
merged 1 commit into from Nov 4, 2020
Merged

nixos/dhcpcd: if disabled IPv6 don't solicit or accept IPv6 #101249

merged 1 commit into from Nov 4, 2020

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Oct 21, 2020

Motivation for this change

Don't solicit or accept IPv6 Router Advertisements and DHCPv6 if networking.enableIPv6 = false
And skip this logs:

dhcpcd[116395]: dev: loaded udev
dhcpcd[116395]: DUID 00:04:80:ae:ba:...
dhcpcd[116395]: eno1: IAID 67:...
dhcpcd[116395]: ipv6_addaddr1: Permission denied
dhcpcd[116395]: eno1: adding address fe80::21e:...
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 30, 2020

cc @aanderse @flokli @Mic92 @ajs124

@flokli
Copy link
Contributor

flokli commented Nov 1, 2020

@Izorkin does this cover NetworkManager too, as reported in #87802?

@flokli flokli mentioned this pull request Nov 1, 2020
Open
@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 2, 2020

@flokli this only covers the DHCP server

@Mic92 Mic92 merged commit f2ec450 into NixOS:master Nov 4, 2020
@Izorkin Izorkin deleted the dhcpd-ipv6 branch November 4, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @flokli @Mic92