Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gogs: 0.11.91 -> 0.12.3 #102061

Merged
merged 1 commit into from Nov 29, 2020
Merged

gogs: 0.11.91 -> 0.12.3 #102061

merged 1 commit into from Nov 29, 2020

Conversation

braunse
Copy link
Contributor

@braunse braunse commented Oct 29, 2020 •
edited by gebner

Motivation for this change

Upstream release: https://github.com/gogs/gogs/releases/tag/v0.12.3
FIxes:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@braunse
Copy link
Contributor Author

braunse commented Oct 29, 2020

Result of nixpkgs-review pr 102061 1

1 package built:
  • gogs

@braunse
Copy link
Contributor Author

braunse commented Oct 29, 2020

Closure size comparison:

/nix/store/lffwq0nv4djkbwmxsv0a67z84q2ql8bf-gogs-0.11.91          448391248  # before
/nix/store/4isb92hw8ivgw1s00wj6qsn94wfw1vxb-gogs-0.12.3           444369544 # after

@ofborg ofborg bot requested review from schneefux and kalbasit October 29, 2020 16:41
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102061 run on x86_64-darwin 1

1 package built:
  • gogs

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102061 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • gogs

@SuperSandro2000
Copy link
Member

Please squash the commits together.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102061 run on x86_64-darwin 1

1 package built:
  • gogs

stigtsp
stigtsp approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102061 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • gogs

Tested OK on linux x64:

  • Enabled via service.gogs
  • Setup using service.gogs.useWizard with sqlite3 backend
  • Created repo, pushed commit via http

@stigtsp stigtsp merged commit e2968a0 into NixOS:master Nov 29, 2020
This was referenced Feb 1, 2021
Closed
Closed
Closed
@dotlambda
Copy link
Member

Can we backport the update without making a breaking change in the NixOS module?

@dotlambda dotlambda mentioned this pull request Feb 1, 2021
Merged
10 tasks
@gebner gebner mentioned this pull request Apr 3, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@stigtsp stigtsp stigtsp approved these changes

@schneefux schneefux Awaiting requested review from schneefux

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
1.severity: security 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@braunse @SuperSandro2000 @dotlambda @stigtsp @mweinelt