Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] FusionInventory: 2.3.21 -> 2.5.2 #102035

Closed
wants to merge 1 commit into from
Closed

[20.09] FusionInventory: 2.3.21 -> 2.5.2 #102035

wants to merge 1 commit into from

Conversation

spacefrogg
Copy link
Contributor

Motivation for this change

Backport to unbreak.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Oct 29, 2020
View reviewed changes
pkgs/servers/monitoring/fusion-inventory/default.nix
@@ -68,6 +54,8 @@ perlPackages.buildPerlPackage rec {
XMLTreePP
];

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment why the tests are disabled?

Also it would be good if we first merge this into master and then backport.

@spacefrogg spacefrogg marked this pull request as draft October 29, 2020 13:28
@spacefrogg
Copy link
Contributor Author

spacefrogg commented Oct 29, 2020 •
edited

Converted to draft. Waiting for merge in master.
EDIT: Relevant PR #102034

@roberth roberth changed the base branch from nixos-20.09 to release-20.09 February 8, 2021 11:42
@mweinelt
Copy link
Member

mweinelt commented Jul 5, 2021

Unfortunately NixOS 20.09 has reached its end-of-life status on 2021-07-01, one
month after the release of NixOS 21.05.

Since we do not accept any changes to its branches anymore, I'm closing this pull
request.

@mweinelt mweinelt closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spacefrogg @mweinelt @SuperSandro2000