Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amdvlk: 2020.Q4.1 -> 2020.Q4.2 #102073

Merged
merged 1 commit into from Nov 2, 2020
Merged

amdvlk: 2020.Q4.1 -> 2020.Q4.2 #102073

merged 1 commit into from Nov 2, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Oct 29, 2020

Motivation for this change

2020.Q4.2 was published: https://github.com/GPUOpen-Drivers/AMDVLK/releases/tag/v-2020.Q4.2

Things done
  • Tested vkcube and dota 2
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from danieldk October 29, 2020 17:09
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 29, 2020 •
edited

Result of nixpkgs-review pr 102073 run on x86_64-linux 1

2 packages failed to build:
  • amdvlk
  • driversi686Linux.amdvlk
CMake Error at /nix/store/r9djcvv9hh6cma006jxlcz3xljz7zck0-cmake-3.18.2/share/cmake-3.18/Modules/CMakeTestCCompiler.cmake:66 (message):
  The C compiler

    "/nix/store/8madhhcxhxlf0rrc5hdsk65l206r3cc6-gcc-wrapper-9.3.0/bin/gcc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /build/amdvlk-src/build/CMakeFiles/CMakeTmp

    Run Build Command(s):/nix/store/ba77flp1iya22w2v7yih1vwz8z4zwdnb-ninja-1.10.1/bin/ninja cmTC_a68c3 && ninja: fatal: posix_spawn: No such file or directory





  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:130 (project)


-- Configuring incomplete, errors occurred!
See also "/build/amdvlk-src/build/CMakeFiles/CMakeOutput.log".

@Flakebi
Copy link
Member Author

Flakebi commented Oct 30, 2020 •
edited

Result of nixpkgs-review pr 102073 1

2 packages built:
  • amdvlk
  • driversi686Linux.amdvlk

Works fine for me.
Does /nix/store/ba77flp1iya22w2v7yih1vwz8z4zwdnb-ninja-1.10.1/bin/ninja exist on your system? (It should be pulled in by the package definition)

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102073 run on x86_64-linux 1

2 packages built:
  • amdvlk
  • driversi686Linux.amdvlk

danieldk
danieldk approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@danieldk danieldk merged commit f38d5cf into NixOS:master Nov 2, 2020
@Flakebi Flakebi deleted the amdvlk branch November 2, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flakebi @SuperSandro2000 @danieldk