pythonPackages.pyqtgraph: use PyQt5 and enable tests #102100
Closed
+33
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 3 packages marked as broken and skipped:
7 packages failed to build:
|
|
Result of 3 packages marked as broken and skipped:
7 packages failed to build:
cat logs/python38Packages.pyqtgraph.log My suggested fix does not work. Not sure why. |
Test results on Linuxsys.platform: linux
sys.version: 3.8.6 (default, Sep 23 2020, 13:54:27)
[GCC 9.3.0]
qt bindings: PyQt5 5.15.1 Qt 5.15.0
pyqtgraph: 0.11.0; None
config:
{'antialias': False,
'background': 'k',
'crashWarning': False,
'editorCommand': None,
'enableExperimental': False,
'exitCleanup': True,
'foreground': 'd',
'imageAxisOrder': 'col-major',
'leftButtonPan': True,
'useOpenGL': False,
'useWeave': False,
'weaveDebug': False}
============================= test session starts ==============================
platform linux -- Python 3.8.6, pytest-5.4.3, py-1.9.0, pluggy-0.13.1 -- /nix/store/346skv0d24rqnf4npknbp9h5bs14j8zy-python3-3.8.6/bin/python3.8
cachedir: .pytest_cache
rootdir: /build/source, inifile: pytest.ini
collecting ... QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/build/runtime-nixbld'
collected 137 items / 7 deselected / 130 selected
Which test is failing? --- a/pkgs/development/python-modules/pyqtgraph/default.nix
+++ b/pkgs/development/python-modules/pyqtgraph/default.nix
@@ -39,7 +39,7 @@ in buildPythonPackage rec {
export FONTCONFIG_FILE=${fontsConf}
# disable 6 tests which try to clone https://github.com/pyqtgraph/test-data
- ${python.interpreter} test.py --pyqt5 \
+ ${python.interpreter} test.py --pyqt5 -s -v \
-k "not test_ImageItem and not test_ImageItem_axisorder \
and not test_PlotCurveItem and not test_getArrayRegion \
and not test_getArrayRegion_axisorder and not test_PolyLineROI" |
FRidh
reviewed
Oct 30, 2020
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
nbke
force-pushed
the
update-pyqtgraph
branch
from
9f815ff to
dd56df4
Compare
|
Does QT even work on Darwin? |
SuperSandro2000
requested changes
Nov 25, 2020
| propagatedBuildInputs = [ scipy numpy pyqt4 pyopengl ]; | ||
| propagatedBuildInputs = [ numpy pyqt5 scipy pyopengl h5py ]; | ||
|
|
||
| checkInputs = [ pytest ]; |
There was a problem hiding this comment.
Please use pytestCheckHook.
|
Can you solve the merge conflict? |
SuperSandro2000
added
the
2.status: merge conflict
11 tasks
|
Superseded by #130560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Use
fetchFromGitHubbecause the tests aren't included in the PyPi package.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)