cargo-tauri-bundler: init at 0.9.3 #102064
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onsails
force-pushed
the
cargo-tauri-bundler
branch
4 times, most recently
from
130a9ea
to
e88ee3c
Compare
onsails
force-pushed
the
cargo-tauri-bundler
branch
2 times, most recently
from
6b6453a
to
c550d6b
Compare
SuperSandro2000
requested changes
Oct 29, 2020
onsails
force-pushed
the
cargo-tauri-bundler
branch
2 times, most recently
from
86ed8b1
to
f76f091
Compare
|
Result of |
onsails
force-pushed
the
cargo-tauri-bundler
branch
from
f76f091
to
6807c1f
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
| onsails = { | ||
| email = "andrey@onsails.com"; | ||
| github = "onsails"; | ||
| githubId = 107261; |
There was a problem hiding this comment.
Adding maintainer requires to be put in a separate commit per contributing guide.
|
|
||
| cargoSha256 = "f55QXLm4qix52Y624pBypIPgvv0ApdT2XrWFkAK9TKM="; | ||
|
|
||
| buildInputs = [ ] ++ lib.optionals stdenv.isDarwin [ |
There was a problem hiding this comment.
Suggested change
| buildInputs = [ ] ++ lib.optionals stdenv.isDarwin [ | |
| buildInputs = lib.optionals stdenv.isDarwin [ |
| description = ''Cargo subcommand "tauri-bundler": wrap Rust executables in OS-specific app bundles''; | ||
| homepage = "https://github.com/tauri-apps/tauri"; | ||
| license = with licenses; [ mit ]; | ||
| platforms = platforms.all; |
There was a problem hiding this comment.
This should not be sit in buildRustPackage .
| homepage = "https://github.com/tauri-apps/tauri"; | ||
| license = with licenses; [ mit ]; | ||
| platforms = platforms.all; | ||
| maintainers = [ maintainers.onsails ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = [ maintainers.onsails ]; | |
| maintainers = with maintainers; [ onsails ]; |
onsails
force-pushed
the
cargo-tauri-bundler
branch
from
6807c1f
to
0793130
Compare
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
onsails
force-pushed
the
cargo-tauri-bundler
branch
from
0793130
to
4c0f007
Compare
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)