Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entt: init at 3.5.2 #102036

Merged
merged 1 commit into from Dec 27, 2020
Merged

entt: init at 3.5.2 #102036

merged 1 commit into from Dec 27, 2020

Conversation

Twey
Copy link
Contributor

@Twey Twey commented Oct 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 29, 2020 •
edited

Result of nixpkgs-review pr 102036 run on x86_64-linux 1

1 package failed to build:
  • entt
-- Check for working CXX compiler: /nix/store/8madhhcxhxlf0rrc5hdsk65l206r3cc6-gcc-wrapper-9.3.0/bin/g++ - broken
CMake Error at /nix/store/r9djcvv9hh6cma006jxlcz3xljz7zck0-cmake-3.18.2/share/cmake-3.18/Modules/CMakeTestCXXCompiler.cmake:59 (message):
  The C++ compiler

    "/nix/store/8madhhcxhxlf0rrc5hdsk65l206r3cc6-gcc-wrapper-9.3.0/bin/g++"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /build/source/build/CMakeFiles/CMakeTmp

    Run Build Command(s):/nix/store/vc851g6wnyyykb5jxgbal3whi5495xia-gnumake-4.3/bin/make cmTC_51798/fast && /nix/store/vc851g6wnyyykb5jxgbal3whi5495xia-gnumake-4.3/bin/make  -f CMakeFiles/cmTC_51798.dir/build.make CMakeFiles/cmTC_51798.dir/build
    make[1]: Entering directory '/build/source/build/CMakeFiles/CMakeTmp'
    make[1]: /bin/sh: No such file or directory
    make[1]: *** [CMakeFiles/cmTC_51798.dir/build.make:84: CMakeFiles/cmTC_51798.dir/testCXXCompiler.cxx.o] Error 127
    make[1]: Leaving directory '/build/source/build/CMakeFiles/CMakeTmp'
    make: *** [Makefile:140: cmTC_51798/fast] Error 2





  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:28 (project)


-- Configuring incomplete, errors occurred!

@Twey
Copy link
Contributor Author

Twey commented Oct 29, 2020

I don't understand this error. This looks like CMake is generating Makefiles that depend on /bin/sh? /bin/sh isn't mentioned in the CMake of the source.

@Twey
Copy link
Contributor Author

Twey commented Oct 29, 2020

(thank you for the suggestions!)

@Flakebi
Copy link
Member

Flakebi commented Oct 30, 2020 •
edited

Result of nixpkgs-review pr 102036 1

1 package built:
  • entt

Seems to work for me

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102036 run on x86_64-linux 1

1 package built:
  • entt

@Twey @SuperSandro2000
entt: init at 3.5.2
5a17b07 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
SuperSandro2000
SuperSandro2000 reviewed Nov 25, 2020
View reviewed changes
pkgs/development/libraries/entt/default.nix
homepage = "https://github.com/skypjack/entt";
description = "A header-only, tiny and easy to use library for game programming and much more written in modern C++";
maintainers = with maintainers; [ twey ];
license = licenses.mit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add platforms.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No platforms specified means I guess all platforms should be supported.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102036 run on x86_64-linux 1

1 package built:
  • entt

@SuperSandro2000 SuperSandro2000 merged commit c958c1b into NixOS:master Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Flakebi Flakebi Flakebi approved these changes

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Twey @SuperSandro2000 @Flakebi @doronbehar