Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gstreamer: needs Xext build input when x11 is enabled #102032

Merged
merged 1 commit into from Oct 29, 2020
Merged

gstreamer: needs Xext build input when x11 is enabled #102032

merged 1 commit into from Oct 29, 2020

Conversation

paralin
Copy link
Contributor

@paralin paralin commented Oct 29, 2020

Motivation for this change

Fixes #102023

When x11 is enabled, gstreamer-plugins-base requires libXext as a build input.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from matthewbauer October 29, 2020 12:14
@nh2 nh2 mentioned this pull request Oct 29, 2020
Closed
@nh2
Copy link
Contributor

nh2 commented Oct 29, 2020 •
edited

10.rebuild-linux: 1001-2500 labels

@paralin This needs to PR against staging because it's a mass rebuild, please rebase it and change the target branch using Github's Edit button above.

I've built the PR on top of master, there it builds fine, so beyond that, this is good to merge (rationale in #102023 (comment)).

@paralin paralin changed the base branch from master to staging October 29, 2020 13:34
@paralin
gstreamer: needs Xext build input when x11 is enabled
2537e11 
Fixes NixOS#102023

Signed-off-by: Christian Stewart <christian@paral.in>
@paralin paralin force-pushed the fix-gstreamer-plugins-base-xext branch from f504240 to 2537e11 Compare October 29, 2020 13:36
@paralin
Copy link
Contributor Author

paralin commented Oct 29, 2020

@nh2 Done.

@nh2 nh2 merged commit bc2b206 into NixOS:staging Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gstreamer-plugins-base: depends on xext
3 participants
@paralin @nh2 @Janik-Haag