Skip to content

gstreamer: needs Xext build input when x11 is enabled #102032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2020
Merged

gstreamer: needs Xext build input when x11 is enabled #102032

merged 1 commit into from
Oct 29, 2020
+2 −0

Conversation

paralin
Copy link
Contributor

@paralin paralin commented Oct 29, 2020

Motivation for this change

Fixes #102023

When x11 is enabled, gstreamer-plugins-base requires libXext as a build input.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested a review from matthewbauer October 29, 2020 12:14
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 labels Oct 29, 2020
@nh2 nh2 mentioned this pull request Oct 29, 2020
Closed
@nh2
Copy link
Contributor

nh2 commented Oct 29, 2020 •
edited
Loading

10.rebuild-linux: 1001-2500 labels

@paralin This needs to PR against staging because it's a mass rebuild, please rebase it and change the target branch using Github's Edit button above.

I've built the PR on top of master, there it builds fine, so beyond that, this is good to merge (rationale in #102023 (comment)).

@paralin paralin changed the base branch from master to staging October 29, 2020 13:34
@paralin
gstreamer: needs Xext build input when x11 is enabled
2537e11 
Fixes NixOS#102023

Signed-off-by: Christian Stewart <christian@paral.in>
@paralin paralin force-pushed the fix-gstreamer-plugins-base-xext branch from f504240 to 2537e11 Compare October 29, 2020 13:36
@paralin
Copy link
Contributor Author

paralin commented Oct 29, 2020

@nh2 Done.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: vim 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: vim 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 101-500 labels Oct 29, 2020
@nh2 nh2 merged commit bc2b206 into NixOS:staging Oct 29, 2020
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2

@matthewbauer matthewbauer

@FRidh FRidh

@jonringer jonringer

@mmahut mmahut

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gstreamer-plugins-base: depends on xext
3 participants
@paralin @nh2 @Janik-Haag