Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.NetAsyncWebSocket: init at 0.13 #102071

Merged
merged 1 commit into from Oct 30, 2020
Merged

perlPackages.NetAsyncWebSocket: init at 0.13 #102071

merged 1 commit into from Oct 30, 2020

Conversation

zakame
Copy link
Member

@zakame zakame commented Oct 29, 2020

Motivation for this change

https://metacpan.org/pod/Net::Async::WebSocket

This pure Perl module allows accessing WebSockets enabled sites using IO::Async.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zakame zakame requested a review from stigtsp as a code owner October 29, 2020 15:57
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 29, 2020 •
edited

Result of nixpkgs-review pr 102071 run on x86_64-darwin 1

2 packages failed to build:
  • perl530Packages.NetAsyncWebSocket
  • perl532Packages.NetAsyncWebSocket

Tests fail on darwin with sandbox:

running tests
t/00use.t ..... ok
t/01client.t .. ok
t/02server.t .. Cannot allocate listening socket - IO::Socket::INET: Operation not permitted at t/02server.t line 20.
t/02server.t .. Dubious, test returned 1 (wstat 256, 0x100)
No subtests run
t/03cross.t ... Cannot allocate listening socket - IO::Socket::INET: Operation not permitted at t/03cross.t line 18.
t/03cross.t ... Dubious, test returned 1 (wstat 256, 0x100)
No subtests run
t/99pod.t ..... skipped: Test::Pod 1.00 required for testing POD

Test Summary Report
-------------------
t/02server.t (Wstat: 256 Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/03cross.t (Wstat: 256 Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
Files=5, Tests=18,  2 wallclock secs ( 0.04 usr  0.03 sys +  0.86 cusr  0.54 csys =  1.47 CPU)
Result: FAIL
Failed 2/5 test programs. 0/18 subtests failed.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102071 run on x86_64-linux 1

2 packages built:
  • perl530Packages.NetAsyncWebSocket
  • perl532Packages.NetAsyncWebSocket

@zakame
Copy link
Member Author

zakame commented Oct 29, 2020 •
edited

Result of nixpkgs-review pr 102071 run on x86_64-darwin 1
2 packages failed to build:

Thanks for this, though not sure how to resolve as I don't have a Mac here 🤔 since its IO::Socket::INET that complained, it may have to be further up beyond the IO::Async::Stream.

I can probably add doCheck = !stdenv.isDarwin; since the failure only really come from testing (e.g. to apply a test IO::Socket::INET handle in https://metacpan.org/source/PEVANS/Net-Async-WebSocket-0.13/t/02server.t#L20-23)

(Can also disable network testing completely, esp. on sandbox)

@zakame zakame mentioned this pull request Oct 29, 2020
Merged
10 tasks
@zakame zakame force-pushed the contrib/perl-NetAsyncWebSocket branch from 69c08b0 to ec29b39 Compare October 29, 2020 19:31
@SuperSandro2000
Copy link
Member

(Can also disable network testing completely, esp. on sandbox)

I think this failure is because of the sandbox. I would be fine with disabling tests von darwin which is better than a broken package.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102071 run on x86_64-darwin 1

2 packages built:
  • perl530Packages.NetAsyncWebSocket
  • perl532Packages.NetAsyncWebSocket

@stigtsp
Copy link
Member

stigtsp commented Oct 30, 2020

@zakame Hey. Would it be possible to have some tests here as well? (re #102066)

@zakame zakame force-pushed the contrib/perl-NetAsyncWebSocket branch from ec29b39 to 52c05c8 Compare October 30, 2020 15:17
@zakame
Copy link
Member Author

zakame commented Oct 30, 2020

Done 💪

stigtsp
stigtsp approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102071 1

2 packages built:
  • perl530Packages.NetAsyncWebSocket
  • perl532Packages.NetAsyncWebSocket

@stigtsp
Copy link
Member

stigtsp commented Oct 30, 2020

Built and tested OK on darwin x64

@stigtsp
Copy link
Member

stigtsp commented Oct 30, 2020

@GrahamcOfBorg build perlPackages.NetAsyncWebSocket perldevelPackages.NetAsyncWebSocket

@stigtsp stigtsp merged commit b52da4e into NixOS:master Oct 30, 2020
@zakame
Copy link
Member Author

zakame commented Oct 30, 2020

Thanks again! 🎉

@zakame zakame deleted the contrib/perl-NetAsyncWebSocket branch October 30, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zakame @SuperSandro2000 @stigtsp