Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DynamicUser=true for hoogle #102076

Merged
merged 1 commit into from Dec 2, 2020
Merged

Set DynamicUser=true for hoogle #102076

merged 1 commit into from Dec 2, 2020

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Oct 29, 2020

I've also removed PrivateTmp = true because this is implied by dynamic user.

I've left ProtectHome = true because I believe this is stronger than
ProtectHome = "read-only" which DynamicUser implies.

Motivation for this change

#55370

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Oct 29, 2020 •
edited

Once merged we can check hoogle off this list. ignore me...

@aanderse
Copy link
Member

So... we're good to merge, right?

@Taneb
nixos/services/hoogle use DynamicUser instead of nobody
12c3e0a 
I've also removed PrivateTmp = true because this is implied by dynamic user.

I've left ProtectHome = true because I believe this is stronger than
ProtectHome = "read-only" which DynamicUser implies.
@Taneb
Copy link
Contributor Author

Taneb commented Nov 30, 2020

I've rebased and force-pushed try and kickstart the ofborg build

@infinisil infinisil merged commit 2526f22 into NixOS:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Taneb @aanderse @SuperSandro2000 @infinisil