Skip to content

Set DynamicUser=true for hoogle #102076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2020
Merged

Set DynamicUser=true for hoogle #102076

merged 1 commit into from
Dec 2, 2020
+1 −3

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Oct 29, 2020

I've also removed PrivateTmp = true because this is implied by dynamic user.

I've left ProtectHome = true because I believe this is stronger than
ProtectHome = "read-only" which DynamicUser implies.

Motivation for this change

#55370

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Taneb Taneb force-pushed the hoogle-dynamic-user branch from 3b6acdc to 24c2d26 Compare October 29, 2020 17:10
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 29, 2020
@aanderse
Copy link
Member

aanderse commented Oct 29, 2020 •
edited
Loading

Once merged we can check hoogle off this list. ignore me...

@aanderse
Copy link
Member

So... we're good to merge, right?

@Taneb
nixos/services/hoogle use DynamicUser instead of nobody

Verified

This commit was signed with the committer’s verified signature.
dywedir Vlad M.
GPG key ID: BE743C5DD7703515
Verified
Learn about vigilant mode
12c3e0a 
I've also removed PrivateTmp = true because this is implied by dynamic user.

I've left ProtectHome = true because I believe this is stronger than
ProtectHome = "read-only" which DynamicUser implies.
@Taneb Taneb force-pushed the hoogle-dynamic-user branch from 24c2d26 to 12c3e0a Compare November 30, 2020 13:36
@Taneb
Copy link
Contributor Author

Taneb commented Nov 30, 2020

I've rebased and force-pushed try and kickstart the ofborg build

@infinisil infinisil merged commit 2526f22 into NixOS:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Taneb @aanderse @SuperSandro2000 @infinisil