Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add part data for all parts #1476

Closed
litghost opened this issue Oct 29, 2020 · 6 comments · Fixed by #1562
Closed

Add part data for all parts #1476

litghost opened this issue Oct 29, 2020 · 6 comments · Fixed by #1562

Comments

@litghost
Copy link
Contributor

Once #1475 is complete, populate part data for all parts that fabric documentation exists for. #1475 should be done first to avoid duplicating all of the fabric data repeatedly.

@dnltz
Copy link
Contributor

dnltz commented Jan 14, 2021

@litghost - Before I will start I have some questions:

  1. Where do I know the fabric documentation exists? Because the script in settings/ exists?
  2. Where do I know devices share the same fabric?
  3. Any restrictions on the parts or do you want all available packages, devices and speed grades?

@litghost
Copy link
Contributor Author

I would start with a family, e.g. "artix7". Example:

get_parts -filter "FAMILY == artix7"

@litghost
Copy link
Contributor Author

  • Where do I know devices share the same fabric?

I think the default is each device is a different fabric, and add a file that specifies which devices are the same fabric. Does that make sense?

@dnltz
Copy link
Contributor

dnltz commented Jan 14, 2021

Ah, that's a brilliant way to fetch all available parts, thanks!

Okay. I understood different devices share the same fabric as well. Makes absolutely sense to me now. That's also the reason for: #1549

@dnltz
Copy link
Contributor

dnltz commented Jan 16, 2021

hey @litghost, I wrote a script to populate all supported parts. Should I also extend the Makefile to roi_only all parts during the CI runs?

@litghost
Copy link
Contributor Author

hey @litghost, I wrote a script to populate all supported parts. Should I also extend the Makefile to roi_only all parts during the CI runs?

Yep, exactly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants