Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wayland: make reproducible #102038

Merged
merged 1 commit into from
Oct 29, 2020
Merged

wayland: make reproducible #102038

merged 1 commit into from
Oct 29, 2020
+9 −1

Conversation

alyssais
Copy link
Member

Upstream MR:
https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/93

I’m the one responsible for making this package non-reproducible in the first place, since I enabled the documentation in #92128.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@SuperSandro2000
Copy link
Member

Don't take blame for that. As long as you don't break something on purpose and you help fixing it everything is fine.

grahamc
grahamc approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 I of course would prefer upstream make their own IDs consistent, but making it better is always good :D #55421 (comment)

@ofborg ofborg bot requested review from codyopel and primeos October 29, 2020 12:52
@alyssais
wayland: make reproducible

Verified

This commit was signed with the committer’s verified signature. The key has expired.
alyssais Alyssa Ross
GPG key ID: F9DBED4859B271C0
Expired
Verified
Learn about vigilant mode
dfe75b9 
Upstream MR:
https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/93
@ofborg ofborg bot requested a review from primeos October 29, 2020 13:24
primeos
primeos approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again :)

@primeos primeos merged commit 350df0f into NixOS:staging Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc

@primeos primeos

@codyopel codyopel

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @SuperSandro2000 @grahamc @primeos