Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pango: fix building on darwin #102059

Merged
merged 1 commit into from Oct 30, 2020
Merged

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Motivation for this change

#102020

Run-time dependency freetype2 found: YES 23.4.17
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency xft found: NO (tried pkgconfig and framework)
meson.build:352:0: ERROR: Dependency "xft" not found, tried pkgconfig and framework
A full log can be found at /private/var/folders/r4/k85s52jx3555ckj0wty615s00000gp/T/nix-build-pango-1.47.0.drv-0/pango-1.47.0/build/meson-logs/meson-log.txt
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, xft is a feature option and from the description I assume that it only works with X11 anyway, so disabling it makes sense.

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Oct 29, 2020

LGTM, xft is a feature option and from the description I assume that it only works with X11 anyway, so disabling it makes sense.

It should be disabled on auto (the default value) but that somehow broke on the last update I think.

@primeos
Copy link
Member

primeos commented Oct 29, 2020

It should be disabled on auto (the default value) but that somehow broke on the last update I think.

IMO that would be strange, it should be enabled by default. At least on Linux we use -Dauto_features=enabled for quite some time now (enables all features, previously we disabled them by default). But I'm not sure if we have any Darwin hacks for this.

@rnhmjoj rnhmjoj requested a review from jtojnar October 29, 2020 18:34
@veprbl veprbl self-assigned this Oct 29, 2020
@veprbl
Copy link
Member

veprbl commented Oct 29, 2020

Apparently the breakage happened as the result of GNOME/pango@8485a34

@SuperSandro2000
Copy link
Member Author

Hope ofborg evals no rebuilds for linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants