Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.curly: unstable-2019-11-14 → 0.2.0 #102081

Merged
merged 1 commit into from Oct 30, 2020
Merged

ocamlPackages.curly: unstable-2019-11-14 → 0.2.0 #102081

merged 1 commit into from Oct 30, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 29, 2020

Motivation for this change

Tests fail on macOS:
#101995 (comment)

cc @sternenseemann @SuperSandro2000

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 29, 2020 •
edited

Result of nixpkgs-review pr 102081 run on x86_64-linux 1

2 packages failed to build:
  • dune-release
  • ocamlPackages.curly
builder for '/nix/store/9081d5r67g1y5phj1g9skk00f93lbqmr-ocaml4.10.0-x509-0.11.2.drv' failed with exit code 1; last 10 log lines:                                                             setting SOURCE_DATE_EPOCH to timestamp 1589460357 of file x509-v0.11.2/x509.opam
  patching sources
  configuring
  no configure script, doing nothing
  building
      ocamlopt lib/.x509.objs/native/x509__.{cmx,o} (exit 2)
  (cd _build/default && /nix/store/73wmqn80qnyywp3lyhzhianby333p7dz-ocaml-4.10.0/bin/ocamlopt.opt -w -40 -w -49 -nopervasives -nostdlib -g -I lib/.x509.objs/byte -I lib/.x509.objs/native -I lib/.x509.objs/public_cmi -intf-suffix .ml-gen -no-alias-deps -o lib/.x509.objs/native/x509__.cmx -c -impl lib/x509__.ml-gen)
  File "lib/x509__.ml-gen", line 1:
  Error: I/O error: as  -o 'lib/.x509.objs/native/x509__.o' '/build/camlasmff4ce6.s': No such file or directory
  Done: 137/180 (jobs: 1)
cannot build derivation '/nix/store/6dg4cjjjcb9zb66nrjk6ahvk2ndb2rma-ocaml4.10.0-tls-0.12.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/grzcvazlccd53ghc9kp4g2y3i6jhm3rm-ocaml4.10.0-conduit-lwt-unix-2.2.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/8nnscwybg94j2z4jy9axxxirm20p23lq-ocaml4.10.0-cohttp-lwt-unix-2.5.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/8jp75p424zkm53wc4p5zkmp3lyiz8vfl-ocaml4.10.0-curly-0.2.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/xc9c066wbampwbirswqy2q3k5a8d0fzb-ocaml4.10.0-dune-release-1.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/asr77082xwd8cj4axcjnrh0ar5gz15y5-env.drv': 2 dependencies couldn't be built
[2 built (1 failed), 105 copied (1108.4 MiB), 212.3 MiB DL]
error: build of '/nix/store/asr77082xwd8cj4axcjnrh0ar5gz15y5-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/102081
2 packages failed to build:
dune-release ocamlPackages.curly

@vbgl
Copy link
Contributor Author

vbgl commented Oct 29, 2020

@GrahamcOfBorg build dune-release

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102081 run on x86_64-darwin 1

1 package built:
  • dune-release

sternenseemann
sternenseemann approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds fine on x86_64 linux

@vbgl vbgl merged commit bb38f05 into NixOS:master Oct 30, 2020
@vbgl vbgl deleted the ocaml-curly-0.2.0 branch October 30, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @SuperSandro2000 @sternenseemann