Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libguestfs: inherit hydraPlatforms from appliance #102098

Merged
merged 1 commit into from
Oct 29, 2020
Merged

libguestfs: inherit hydraPlatforms from appliance #102098

merged 1 commit into from
Oct 29, 2020
+2 −0

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 29, 2020 •
edited
Loading

Motivation for this change

forward port of #102077

(cherry picked from commit 265f2f5)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@jonringer
libguestfs: inherit hydraPlatforms from appliance

Verified

This commit was signed with the committer’s verified signature.
lforst Luca Forstner
SSH Key Fingerprint: ljpBJ7bYHpwPGV7Y7sJZM+cMS44wfy1fkQqwY/900Nw
Verified
Learn about vigilant mode
c6bc0d5 
(cherry picked from commit 265f2f5)
@jonringer jonringer requested a review from cole-h October 29, 2020 20:11
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 29, 2020
@jonringer jonringer merged commit e57cbfc into NixOS:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @cole-h