Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] servant: generate docs using python3 #102067

Merged
merged 1 commit into from Oct 29, 2020
Merged

[20.09] servant: generate docs using python3 #102067

merged 1 commit into from Oct 29, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 29, 2020 •
edited

Motivation for this change

part of #101964

(cherry picked from commit 59c53bc)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer changed the title servant: generate docs using python3 [20.09] servant: generate docs using python3 Oct 29, 2020
@jonringer
Copy link
Contributor Author 

https://github.com/NixOS/nixpkgs/pull/102067
2 packages built:
cachix hercules-ci-agent

@jonringer jonringer merged commit 4e72efc into NixOS:release-20.09 Oct 29, 2020
@jonringer jonringer deleted the backport-servant branch October 29, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout cdepillabout is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @domenkozar