Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/pdns-recursor: use upstream systemd unit #100892

Merged
merged 4 commits into from Oct 19, 2020
Merged

nixos/pdns-recursor: use upstream systemd unit #100892

merged 4 commits into from Oct 19, 2020

Conversation

aanderse
Copy link
Member

Motivation for this change

pdns-recursor upstream offers really good systemd units, compared to many other software vendors. We should use what they provide.

@rnhmjoj I'm not sure if the third commit "declare module user as system user" is desired or not, but I thought that seems to be the way things are going since RFC 52 so I figured I would throw it in here. If this isn't desired feel free to mention and I can toss it.

I don't run pdns-recursor (or dnsdist, or powerdns, for that matter) yet. I have started reviewing this software for potential use, but I'm not able to properly test these yet. I'll depend on you to adequately test this PR, if you don't mind.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse requested a review from rnhmjoj October 17, 2020 22:07
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Oct 17, 2020

I'll depend on you to adequately test this PR, if you don't mind.

Sure! I have been running pdns-recursor for a few years (nothing fancy besides a custom forward zone), though I don't use powerdns or dnsdist. So, about the other PRs what you tried/tested is probably more than I can do but I'll try review to review them all.

@aanderse
Copy link
Member Author

@ofborg eval

@ofborg ofborg bot requested a review from rnhmjoj October 18, 2020 00:48
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Oct 18, 2020

@GrahamcOfBorg test pdns-recursor ncdns

@aanderse
Copy link
Member Author

@rnhmjoj I think I have addressed all concerns. Let me know what you think.

rnhmjoj
rnhmjoj approved these changes Oct 18, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good now and my tests are passing. Seems good to go.

@aanderse
Copy link
Member Author

As always, thanks for your review @rnhmjoj 🎉

@aanderse aanderse merged commit 5265d49 into NixOS:master Oct 19, 2020
@aanderse aanderse deleted the pdns-recursor branch October 19, 2020 00:13
@aanderse aanderse mentioned this pull request Nov 12, 2020
Open
@aanderse aanderse mentioned this pull request Jan 3, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @rnhmjoj