Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: e6247a584dc2
Choose a base ref
...
head repository: NixOS/nix
compare: 05e6fe69f91a
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on Oct 17, 2020

  1. Convert VM tests to Python 

    Perl-based tests are deprecated since NixOS 20.03 and subsequently got
removed in NixOS 20.09, which effectively means that tests are going to
fail as soon as we build it with NixOS 20.09 or anything newer.

I've put "# fmt: off" at the start of every testScript, because
formatting with Black really messes up indentation and I don't think it
really adds anything in value or readability for inlined Python scripts.

Signed-off-by: aszlig <aszlig@nix.build>
    @aszlig
    aszlig committed Oct 17, 2020
    Copy the full SHA
    5cfdf16 View commit details
    Browse the repository at this point in the history

  2. tests: Add names to VM tests 

    Having vm-test-run-unnamed for all the test derivation doesn't look very
nice, so in order to better distinguish them from their store path,
let's actually give them proper names.

Signed-off-by: aszlig <aszlig@nix.build>
    @aszlig
    aszlig committed Oct 17, 2020
    Copy the full SHA
    cfa26cf View commit details
    Browse the repository at this point in the history

  3. Merge pull request #4156 from aszlig/vm-test-python 

    Convert VM tests to Python
    @edolstra
    edolstra committed Oct 17, 2020
    Copy the full SHA
    05e6fe6 View commit details
    Browse the repository at this point in the history