Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mathematica: Prefer building locally #100856

Merged
merged 1 commit into from Nov 20, 2020
Merged

mathematica: Prefer building locally #100856

merged 1 commit into from Nov 20, 2020

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Oct 17, 2020

Motivation for this change

There is little benefit to copying a 4GB tarball over the network,
just to perform an I/O-bound operation and then copy the
multi-gigabyte result back.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bgamari
mathematica: Prefer building locally
4c0759a 
There is little benefit to copying a 4GB tarball over the network,
just to perform an I/O-bound operation and then copy the
multi-gigabyte result back.
@ofborg ofborg bot requested a review from herberteuler October 17, 2020 18:31
@bgamari
Copy link
Contributor Author

bgamari commented Oct 17, 2020

CC @herberteuler

veprbl
veprbl approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@veprbl veprbl merged commit 7263f7c into NixOS:master Nov 20, 2020
veprbl pushed a commit that referenced this pull request Nov 20, 2020
@bgamari @veprbl
mathematica: Prefer building locally (#100856)
a371a5d 
There is little benefit to copying a 4GB tarball over the network,
just to perform an I/O-bound operation and then copy the
multi-gigabyte result back.

(cherry picked from commit 7263f7c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma approved these changes

@veprbl veprbl veprbl approved these changes

@herberteuler herberteuler herberteuler approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bgamari @wamserma @veprbl @herberteuler