Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.datasette: minimize test time #100862

Merged
merged 1 commit into from Oct 17, 2020
Merged

python3Packages.datasette: minimize test time #100862

merged 1 commit into from Oct 17, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 17, 2020 •
edited

Motivation for this change

noticed while reviewing #100762 that datasette was running tests for over an hour.

This makes the tests take less than a minute. Not quite great for the datasette package, but I think this is a fair compromise.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner October 17, 2020 18:53
jonringer
jonringer commented Oct 17, 2020
View reviewed changes
Copy link
Contributor Author

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

https://github.com/NixOS/nixpkgs/pull/100862
2 packages built:
datasette python37Packages.datasette

@jonringer jonringer merged commit 67f6707 into NixOS:master Oct 17, 2020
@jonringer jonringer deleted the datasette-tests branch October 17, 2020 18:56
@ofborg ofborg bot requested a review from costrouc October 17, 2020 19:04
@jonringer jonringer mentioned this pull request Oct 18, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer