Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uemacs: remove #101112

Merged
merged 1 commit into from Oct 30, 2020
Merged

uemacs: remove #101112

merged 1 commit into from Oct 30, 2020

Conversation

deviant
Copy link
Member

@deviant deviant commented Oct 20, 2020 •
edited

This crashes with a buffer overflow upon running it. It has likely been
broken for some time. It has no maintainers. It is also unfree.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@deviant
uemacs: remove
3835f35 
This crashes with a buffer overflow upon running it. It has likely been
broken for some time. It has no maintainers. It is also unfree.
@worldofpeace worldofpeace merged commit 99600df into NixOS:master Oct 30, 2020
@worldofpeace
Copy link
Contributor

Could u open a backport to stable?

@deviant deviant mentioned this pull request Oct 30, 2020
Merged
10 tasks
@deviant
Copy link
Member Author

deviant commented Oct 30, 2020

@worldofpeace Done.

@deviant deviant deleted the remove-uemacs branch October 30, 2020 20:46
@emilylange emilylange mentioned this pull request Jan 21, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deviant @worldofpeace @wamserma