Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastd: 19 -> 21 #101091

Merged
merged 1 commit into from Oct 23, 2020
Merged

fastd: 19 -> 21 #101091

merged 1 commit into from Oct 23, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 19, 2020 •
edited

Motivation for this change

New upstream releases.

https://fastd.readthedocs.io/en/stable/releases/v20.html
https://fastd.readthedocs.io/en/stable/releases/v21.html

Faster than expected, there is a new release of fastd, fixing a critial
Denial of Service (fastd crash) vulnerability. All users of fastd v20 must
update.

In fastd v19 and older, the same vulnerablity exists, but exploiting it
will cause a memory leak rather than an instant crash. Users that can't or
do not want to update to v21 yet should apply the patch that is attached to
this mail.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt requested a review from fpletz October 19, 2020 20:09
@mweinelt
Copy link
Member Author

mweinelt commented Oct 22, 2020 •
edited

CVE-2020-27638 was just assigned to this problem, cmp. https://security-tracker.debian.org/tracker/CVE-2020-27638.

@andir
Copy link
Member

andir commented Oct 23, 2020

Result of nixpkgs-review pr 101091 1

1 package built:
  • fastd

@andir andir merged commit 5506c40 into NixOS:master Oct 23, 2020
@mweinelt mweinelt deleted the fastd branch October 23, 2020 13:15
@mweinelt mweinelt mentioned this pull request Nov 4, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @andir