plata-theme: 0.9.8 -> 0.9.9 #101093
plata-theme: 0.9.8 -> 0.9.9 #101093
Conversation
| buildInputs = [ | ||
| gdk-pixbuf | ||
| librsvg |
There was a problem hiding this comment.
From reading https://gitlab.com/tista500/plata-theme#installation-from-git-source, I would expect librsvg to be needed for generating images or something. So it should probably go to nativeBuildInputs.
But here it looks like gdk-pixbuf is needed as a library: https://gitlab.com/tista500/plata-theme/-/blob/1dd0953f1d6a35777388d39f46e2428c038042be/configure.ac#L42
There was a problem hiding this comment.
librsvg is not needed or mentioned anywhere in the repo; inkscape is used to generate images.
gdk-pixbuf seems to be a sanity check, there's not really a reason to require it to build the theme. I added it to nativeBuildInputs just in case it causes an error.
|
Result of 1 package built:
|
|
@tadfisher would you mind rebasing this? :) |
tadfisher
force-pushed
the
plata-theme
branch
from
809621c
to
b943976
Compare
|
@IvarWithoutBones Rebased, thanks. |
pkgs/data/themes/plata/default.nix
Outdated
| librsvg | ||
| # GTK2 engines must be on the system path at runtime to be loaded. | ||
| propagatedUserEnvPkgs = [ | ||
| gtk2 |
There was a problem hiding this comment.
afaik only gtk-engine-murrine needs to be in propagatedUserEnvPkgs, if so gtk2 should be in buildInputs
There was a problem hiding this comment.
And probably gtk_engines instead of gtk2.
Motivation for this change
buildInputsas this derivation produces static files with no binary dependencies.propagatedUserEnvPkgsfor GTK2 support at runtime.0.9.9.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)