Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.nestedtext: init at 1.2 #101109

Merged
merged 2 commits into from Nov 7, 2020
Merged

pythonPackages.nestedtext: init at 1.2 #101109

merged 2 commits into from Nov 7, 2020

Conversation

jeremyschlatter
Copy link
Contributor

@jeremyschlatter jeremyschlatter commented Oct 20, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jeremyschlatter
Copy link
Contributor Author

@AndersonTorres thanks for the review! I just incorporated your feedback.

@AndersonTorres
Copy link
Member

Fine. I will just wait Borg finish and accept the PR.

@jeremyschlatter jeremyschlatter changed the title nestedtext: init at 1.1.0 nestedtext: init at 1.2 Nov 6, 2020
@AndersonTorres
Copy link
Member

A little bit of annoyance: get rid of those "commit code review suggestion" messages by rebasing/squashing those commits. Those messages can't appear in the final tree of Nixpkgs.

Many thanks!

@jeremyschlatter jeremyschlatter changed the title nestedtext: init at 1.2 pythonPackages.nestedtext: init at 1.2 Nov 7, 2020
@jeremyschlatter
Copy link
Contributor Author

Done.

@AndersonTorres
Copy link
Member

There's a small forward-tick in a file, but I will not complain this time.

@AndersonTorres AndersonTorres merged commit e45d10d into NixOS:master Nov 7, 2020
@jeremyschlatter jeremyschlatter deleted the nestedtext branch November 7, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants