Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plantuml: 1.2020.16 -> 1.2020.19 #101084

Merged
merged 1 commit into from Oct 19, 2020
Merged

plantuml: 1.2020.16 -> 1.2020.19 #101084

merged 1 commit into from Oct 19, 2020

Conversation

ldeck
Copy link
Contributor

@ldeck ldeck commented Oct 19, 2020

Motivation for this change

Update to the latest available release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [N/A] Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bjornfor October 19, 2020 18:44
@ldeck
Copy link
Contributor Author

ldeck commented Oct 19, 2020

FYI @bjornfor.

Perhaps too it’s worth considering (for future updates) configuring the plantuml derivation with the apache batik dependency so as to support the -tpdf option out of the box.

plantuml -tpdf test.txt
java.lang.ClassNotFoundException: org.apache.batik.apps.rasterizer.SVGConverter
	at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:264)
	at net.sourceforge.plantuml.pdf.PdfConverter.convert(PdfConverter.java:57)
	at net.sourceforge.plantuml.UmlDiagram.exportDiagramInternalPdf(UmlDiagram.java:316)
	at net.sourceforge.plantuml.UmlDiagram.exportDiagramNow(UmlDiagram.java:169)
	at net.sourceforge.plantuml.AbstractPSystem.exportDiagram(AbstractPSystem.java:140)
	at net.sourceforge.plantuml.PSystemUtils.exportDiagramsCuca(PSystemUtils.java:233)
	at net.sourceforge.plantuml.PSystemUtils.exportDiagrams(PSystemUtils.java:89)
	at net.sourceforge.plantuml.SourceFileReaderAbstract.getGeneratedImages(SourceFileReaderAbstract.java:160)
	at net.sourceforge.plantuml.Run.manageFileInternal(Run.java:538)
	at net.sourceforge.plantuml.Run.processArgs(Run.java:422)
	at net.sourceforge.plantuml.Run.manageAllFiles(Run.java:389)
	at net.sourceforge.plantuml.Run.main(Run.java:198)
Exception in thread "main" java.lang.UnsupportedOperationException
	at net.sourceforge.plantuml.pdf.PdfConverter.convert(PdfConverter.java:76)
	at net.sourceforge.plantuml.UmlDiagram.exportDiagramInternalPdf(UmlDiagram.java:316)
	at net.sourceforge.plantuml.UmlDiagram.exportDiagramNow(UmlDiagram.java:169)
	at net.sourceforge.plantuml.AbstractPSystem.exportDiagram(AbstractPSystem.java:140)
	at net.sourceforge.plantuml.PSystemUtils.exportDiagramsCuca(PSystemUtils.java:233)
	at net.sourceforge.plantuml.PSystemUtils.exportDiagrams(PSystemUtils.java:89)
	at net.sourceforge.plantuml.SourceFileReaderAbstract.getGeneratedImages(SourceFileReaderAbstract.java:160)
	at net.sourceforge.plantuml.Run.manageFileInternal(Run.java:538)
	at net.sourceforge.plantuml.Run.processArgs(Run.java:422)
	at net.sourceforge.plantuml.Run.manageAllFiles(Run.java:389)
	at net.sourceforge.plantuml.Run.main(Run.java:198)

@bjornfor
Copy link
Contributor

@ldeck: Thanks! Patches welcome :-)

@bjornfor bjornfor merged commit cbb91a3 into NixOS:master Oct 19, 2020
@ldeck ldeck deleted the plantuml/update/1.2020.16->1.2020.19 branch October 19, 2020 21:49
@McSinyx McSinyx mentioned this pull request Jul 11, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldeck @bjornfor @Janik-Haag