Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[documentation] Update testdriver extension tutorial #26176

Merged
merged 1 commit into from Oct 19, 2020
Merged

[documentation] Update testdriver extension tutorial #26176

merged 1 commit into from Oct 19, 2020

Conversation

stephenmcgruer
Copy link
Contributor

No description provided.

@stephenmcgruer
Copy link
Contributor Author

cc @jgraham as the person who probably knows most about testdriver extensions these days.

I think there's still a few changes I want to make here, but probably in future PRs:

  1. Explain briefly what context is
  2. Use an example that is actually in testdriver.js today (because set-rect isn't!)
  3. Change the wording around 'Chrome' and 'Firefox' to WebDriver and Marionette explicitly, since many (most?) browsers use the WebDriver executor nowadays.

But for now I believe these changes are concrete bug fixes.

@sideshowbarker sideshowbarker removed their assignment Oct 19, 2020
jgraham
jgraham approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea this tutorial even existed...

@stephenmcgruer
Copy link
Contributor Author

It's pretty good! We reference it from our Chromium-specific guide

@stephenmcgruer stephenmcgruer merged commit ff3003e into master Oct 19, 2020
@stephenmcgruer stephenmcgruer deleted the smcgruer/min_window branch October 19, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stephenmcgruer @jgraham @sideshowbarker @wpt-pr-bot