Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib3mf: 1.8.1 → 2.0.0 #101105

Merged
merged 1 commit into from Nov 26, 2020
Merged

lib3mf: 1.8.1 → 2.0.0 #101105

merged 1 commit into from Nov 26, 2020

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 19, 2020 •
edited

Motivation for this change

Failed in https://r.ryantm.com/log/2020-10-17.log

Result of nixpkgs-review 11

2 packages built:
  • lib3mf
  • openscad
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from gebner October 19, 2020 23:29
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 101105 run on x86_64-darwin 1

2 packages built:
  • lib3mf
  • openscad

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 101105 run on x86_64-linux 1

2 packages built:
  • lib3mf
  • openscad

@SuperSandro2000 SuperSandro2000 merged commit 0f98643 into NixOS:master Nov 26, 2020
@SuperSandro2000 SuperSandro2000 deleted the lib3mf-2.0.0 branch November 26, 2020 21:31
@gebner gebner mentioned this pull request Mar 19, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@SuperSandro2000