[20.09] perlPackages.Linux*: disable on non-Linux platforms #101122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b7e4ac4)
zakame
reviewed
Oct 20, 2020
Comment on lines
+10763
to
+10765
| meta = with stdenv.lib; { | ||
| platforms = platforms.linux; | ||
| }; |
There was a problem hiding this comment.
Since this adds a new meta attr, maybe the subAttrs for description and license can be added (taken from metacpan?)
Suggested change
| meta = with stdenv.lib; { | |
| platforms = platforms.linux; | |
| }; | |
| meta = { | |
| description = "Scalable directory/file change notification for Perl on Linux"; | |
| license = with stdenv.lib.licenses; [ artistic1 gpl1Plus ]; | |
| platforms = stdenv.lib.platforms.linux; | |
| }; |
Though I suppose this might be better off in a separate PR altogether.
There was a problem hiding this comment.
This is a backport of a fix. New metadata should be added in master and doesn't need backport imo.
There was a problem hiding this comment.
Yep, I'll go ahead and make that PR to master, thanks 💪
roberth
approved these changes
Oct 20, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #101012
(cherry picked from commit b7e4ac4)
Motivation for this change
ZHF 20.09 #97479
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)