Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc8102BinaryMinimal: fix docs as legally required #102833

Merged
merged 2 commits into from Nov 6, 2020
Merged

ghc8102BinaryMinimal: fix docs as legally required #102833

merged 2 commits into from Nov 6, 2020

Conversation

roberth
Copy link
Member

@roberth roberth commented Nov 4, 2020 •
edited

Motivation for this change

Distribute docs, which is a legal requirement.
This variation of GHC was not intended to be distributed, but it turns out we can't not distribute it.

Forward port of #102504

Please merge with haskell mass-rebuild or after #102662 to keep hydra aarch64-linux load in check

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth
ghc8102BinaryMinimal: Re-add docs, remove more profiling files
dda47e4 
(cherry picked from commit 7bd21d3)
@roberth
ghc8102Binary*: simplify meta
6b377f2 
Not distributing dependencies via hydraPlatforms does not work,
so we keep meta simple.

(cherry picked from commit 4643796)
@roberth roberth changed the title ghc8102BinaryMinimal: fix docs ghc8102BinaryMinimal: fix docs as legally required Nov 5, 2020
@domenkozar domenkozar merged commit fad48e3 into NixOS:staging Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberth @domenkozar