Skip to content

vimPlugins.vim-markdown-composer: init at 2020-08-15 #102824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

vimPlugins.vim-markdown-composer: init at 2020-08-15 #102824

merged 1 commit into from
Nov 18, 2020
+29 −0

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Nov 4, 2020

Motivation for this change

A live preview for markdown files, I’m using it for a while now: https://github.com/euclio/vim-markdown-composer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Flakebi Flakebi requested a review from jonringer as a code owner November 4, 2020 20:41
@ofborg ofborg bot added 6.topic: vim 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 4, 2020
jonringer
jonringer reviewed Nov 4, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

propagatedBuildInputs = [ vim-markdown-composer-bin ];

is probably not needed if you're patching the location into the plugin

@Flakebi Flakebi force-pushed the vim-markdown-composer branch from d1836a8 to 0c7318a Compare November 5, 2020 18:00
@Flakebi
Copy link
Member Author

Flakebi commented Nov 5, 2020

Thank you for the review, it looks a lot cleaner now.

@Flakebi
Copy link
Member Author

Flakebi commented Nov 18, 2020

Friendly ping for review

jonringer
jonringer approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102824 1

1 package built:
  • vimPlugins.vim-markdown-composer

@jonringer jonringer merged commit eafb0c8 into NixOS:master Nov 18, 2020
@Flakebi Flakebi deleted the vim-markdown-composer branch November 18, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flakebi @jonringer