Skip to content

[20.03] ant: 1.10.2 -> 1.10.9 [20.03] #102838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

redvers
Copy link
Member

@redvers redvers commented Nov 4, 2020

Motivation for this change

Addresses #88268 - CVE-2020-1945

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@redvers redvers added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 4, 2020
@mweinelt mweinelt changed the title ant: 1.10.2 -> 1.10.9 [20.03] ant: 1.10.2 -> 1.10.9 Nov 4, 2020
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please backport all version bumps leading up to this one from master.

https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes

@redvers
Copy link
Member Author

redvers commented Nov 4, 2020

Please backport all version bumps leading up to this one from master.

Do I then squash those commits to one, or leave them as two/more commits?

@redvers redvers changed the title [20.03] ant: 1.10.2 -> 1.10.9 [20.03] ant: 1.10.2 -> 1.10.9 [20.03] Nov 4, 2020
@mweinelt
Copy link
Member

mweinelt commented Nov 4, 2020

We like to keep the papertrail intact, which git cherry-pick -x does nicely. Keep every commit as is.

@redvers
Copy link
Member Author

redvers commented Nov 4, 2020

We like to keep the papertrail intact, which git cherry-pick -x does nicely. Keep every commit as is.

When you say cherry-pick from master - does that always mean from nixos/nixpkgs master? ... or can thhat be from my master?
(Reason I ask - if I'm opening up three identical pull requests, one for each branch I'm been cherry-picking from mine so I don't have to wait for the first to be merged)

@mweinelt
Copy link
Member

mweinelt commented Nov 5, 2020

We need to wait for commits to be on nixpkgs master before you pick them, since the commit Ids can still change. So in case of a backport you can only do that, once the commits have hit nixpkgs/master.

@redvers
Copy link
Member Author

redvers commented Nov 5, 2020

We need to wait for commits to be on nixpkgs master before you pick them, since the commit Ids can still change. So in case of a backport you can only do that, once the commits have hit nixpkgs/master.

Guess I'll have to redo all those pull requests then - darn it.

About to tag you on one I think I've followed your procedure on. Please poke me if I'm wrong on it.

@redvers
Copy link
Member Author

redvers commented Nov 6, 2020

@andir

@andir
Copy link
Member

andir commented Nov 9, 2020

Please also pick commit c7224f12c37bc90b452591cd597e1ac8f160d9c9 to this branch (before your latest change) and then this should be fine. You can (and should) also add the cherry-picked reference for the 1.10.8 -> 10.10.9 bump (89cd509).

@redvers
Copy link
Member Author

redvers commented Nov 12, 2020

This is my problem... I can't cherry pick these:

commit d93c4e2f85cefff85d2bc09b696539cfa5189f50
Merge: 9ca1f49410a c7224f12c37
Author: Florian Klink <flokli@flokli.de>
Date:   Mon Aug 17 00:34:42 2020 +0200

    Merge pull request #95600 from dasj19/ant-updates
    
    apache ant: 1.9.6 -> 1.9.15; 1.10.2 -> 1.10.8

More than one update in that commit.

@andir
Copy link
Member

andir commented Nov 12, 2020 via email

@redvers
Copy link
Member Author

redvers commented Nov 21, 2020

They won't commit because the git log history for that file looks like this:

commit 89cd50903d2eebf8c7ba821b54a1665cc232db0a (origin/update_ant_1.10.9)
Author: Red Davies <red@infect.me>
Date:   Wed Nov 4 21:07:36 2020 +0000

    ant: 1.10.8 -> 1.10.9

commit c7224f12c37bc90b452591cd597e1ac8f160d9c9
Author: Daniel Șerbănescu <daniel@serbanescu.dk>
Date:   Sun Aug 16 17:19:35 2020 +0200

    ant: 1.10.2 -> 1.10.8

commit 84cf00f98031e93f389f1eb93c4a7374a33cc0a9
Author: Michael Reilly <OmnipotentEntity@gmail.com>
Date:   Tue Mar 31 21:11:51 2020 -0400

    treewide: Per RFC45, remove all unquoted URLs

84cf00f has never been applied to 20.03 and since that has changes for 9,648 files I can't really apply that one first.

I don't know how to proceed.

@mweinelt
Copy link
Member

Just the apply the two ant commits and fix the conflict locally.

@mweinelt
Copy link
Member

Thank you for your contribution. Unfortunately it is not in a state to be merged as-is, and NixOS 20.03 is EOL as of today.

Closing.

@mweinelt mweinelt closed this Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants