Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpytop: 1.0.21 -> 1.0.50 #102836

Closed
wants to merge 4 commits into from
Closed

bpytop: 1.0.21 -> 1.0.50 #102836

wants to merge 4 commits into from

Conversation

herrwiese
Copy link
Contributor

@herrwiese herrwiese commented Nov 4, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

@jonringer
Copy link
Contributor

I know it's annoying, but it's done for good reason

herrwiese and others added 4 commits November 9, 2020 23:04
@herrwiese
bpytop: 1.0.21 -> 1.0.25
cc164dd 
(cherry picked from commit 5200ee8)
@herrwiese
bpytop: 1.0.25 -> 1.0.42
3386a54 
(cherry picked from commit 861d9d7)
@r-ryantm @herrwiese
bpytop: 1.0.42 -> 1.0.44
5085d07 
(cherry picked from commit 4f6bc70)
@r-ryantm @herrwiese
bpytop: 1.0.44 -> 1.0.47
c874cad 
(cherry picked from commit 69f235c)
@herrwiese herrwiese closed this Nov 9, 2020
@herrwiese herrwiese deleted the for-20.09/bpytop-1.0.50 branch November 9, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@herrwiese @jonringer @r-ryantm