Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniscript: init at unstable-20201104 #102808

Closed
wants to merge 1 commit into from
Closed

miniscript: init at unstable-20201104 #102808

wants to merge 1 commit into from
+31 −0

Conversation

RaghavSood
Copy link
Member

Motivation for this change

Miniscript is a tool to compile and work with the miniscript Bitcoin policy language.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@RaghavSood RaghavSood requested a review from mmahut as a code owner November 4, 2020 16:17
SuperSandro2000
SuperSandro2000 reviewed Nov 4, 2020
View reviewed changes
pkgs/applications/blockchains/miniscript/default.nix Outdated

stdenv.mkDerivation rec {
pname = "miniscript";
version = "unstable-20201104";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "unstable-20201104";
version = "unstable-2020-11-04";

pkgs/applications/blockchains/miniscript/default.nix Outdated
'';

meta = with stdenv.lib; {
description = "Miniscript is a language for writing (a subset of) Bitcoin Scripts in a structured way, enabling analysis, composition, generic signing and more.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is description is quite long. It should probably be moved to longDescription and a shorter one for the short should be used.

@RaghavSood
Copy link
Member Author

@SuperSandro2000 appreciate the quick review, updated

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102808 run on x86_64-linux 1

1 package built:
  • miniscript

@SuperSandro2000
Copy link
Member

Fails to build on darwin with:

building
build flags: SHELL=/nix/store/7kzamk0abm530kkr5v106hnc3cfscwkc-bash-4.4-p23/bin/bash
g++ -O3 -g0 -Wall -std=c++11 -march=native -flto -Ibitcoin bitcoin/util/strencodings.cpp bitcoin/util/spanparsing.cpp bitcoin/script/script.cpp bitcoin/script/miniscript.cpp compiler.cpp main.cpp -o miniscript
/nix/store/7kzamk0abm530kkr5v106hnc3cfscwkc-bash-4.4-p23/bin/bash: g++: command not found
make: *** [Makefile:5: miniscript] Error 127

SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please mark it broken on darwin.

pkgs/applications/blockchains/miniscript/default.nix
runHook postInstall
'';

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

@jb55 jb55 mentioned this pull request May 2, 2021
Merged
jb55 added a commit to jb55/nixpkgs that referenced this pull request May 2, 2021
@RaghavSood @jb55
miniscript: init at unstable-2020-11-04
04ca634 
Closes NixOS#102808

Co-authored-by: William Casarin <jb55@jb55.com>
@RaghavSood RaghavSood closed this May 2, 2021
@RaghavSood RaghavSood deleted the miniscript/init branch May 13, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

@mmahut mmahut

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RaghavSood @SuperSandro2000