Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6336ac33c91a
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 81c5e310438d
Choose a head ref
  • 8 commits
  • 7 files changed
  • 2 contributors

Commits on Nov 4, 2020

  1. iosevka-bin: Use iosevka's meta 

    The two packages have the same metadata, except for the maintainers.
    @AluisioASG
    AluisioASG committed Nov 4, 2020
    Copy the full SHA
    988f0cf View commit details

  2. iosevka-bin: move update script 

    Move bin.nix's update script to update-bin.sh so it doesn't conflict
with default.nix's update script.
    @AluisioASG
    AluisioASG committed Nov 4, 2020
    Copy the full SHA
    e237f23 View commit details

  3. iosevka: 3.2.2 -> 3.7.1; fetch source through nodePackages 

    Previously we used nodePackages only to fetch Iosevka's build
dependencies and then fetched the source code ourselves.  Updates
involved changing the version and hashes in the `iosevka` derivation and
then running node-packages/generate.sh to update the build dependencies,
which in turns updates *all* of node-packages.nix.

A new proposed policy for handling node-packages.nix updates involves
batching those updates.  Previously, that would mean `iosevka` and its
build dependencies could end up out of sync until the batched update was
run.

To work with the new policy, we now fetch Iosevka's source code (and
not only its dependencies) through nodePackages.  Updates are done by
changing the source URL in node-packages.json, which eventually becomes
part of an update of node-packages.nix, which is then propagated to
`iosevka` itself.

One con of this strategy is that errors can not be caught directly
after the update, but only after node-packages.nix is regenerated.
    @AluisioASG
    AluisioASG committed Nov 4, 2020
    Copy the full SHA
    e6bc641 View commit details

  4. iosevka: add update script 

    As outlined in the previous commit, we just need to update the source
URL in node-packages.json, and wait for node-packages.nix to be rebuilt
from it.
    @AluisioASG
    AluisioASG committed Nov 4, 2020
    Copy the full SHA
    26ce7f2 View commit details

  5. iosevka: remove dependency on otfcc 

    As of Iosevka 3.7.0, otfcc is no longer used.  I haven't checked if
the situation has changed since [2017] but this should make Iosevka
available on aarch64-linux and *-darwin.

[2017]: #31835 (comment)
    @AluisioASG
    AluisioASG committed Nov 4, 2020
    Copy the full SHA
    08fd340 View commit details

  6. iosevka: add AluisioASG as maintainer

    @AluisioASG
    AluisioASG committed Nov 4, 2020
    Copy the full SHA
    1ade372 View commit details

  7. nodePackages: update

    @AluisioASG
    AluisioASG committed Nov 4, 2020
    Copy the full SHA
    7d15aa4 View commit details

  8. Merge pull request #99004 from AluisioASG/aasg/iosevka

    @doronbehar
    doronbehar authored Nov 4, 2020
    Copy the full SHA
    81c5e31 View commit details
Loading