Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babashka: 0.0.97 -> 0.2.3 #102867

Merged
merged 1 commit into from Nov 5, 2020
Merged

babashka: 0.0.97 -> 0.2.3 #102867

merged 1 commit into from Nov 5, 2020

Conversation

bennyandresen
Copy link
Contributor

Motivation for this change

with #99631 and #102693 merged, it's possible to bump the babashka
version again.

However recent versions of babashka depend on java11 features and I
spoke in Slack with the project lead and this java11 dependency will
exist going forward.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

@bennyandresen
babashka: 0.0.97 -> 0.2.3
172cbb8 
with NixOS#99631 and NixOS#102693 merged, it's possible to bump the babashka
version again.

However recent versions of babashka depend on java11 features and I
spoke in Slack with the project lead and this java11 dependency will
exist going forward.
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 5, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ofborg ofborg bot requested a review from jlesquembre November 5, 2020 06:44
@timokau timokau mentioned this pull request Nov 5, 2020
Open
timokau
timokau approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@timokau timokau merged commit 6e089d3 into NixOS:master Nov 5, 2020
@bennyandresen bennyandresen deleted the babashka-update branch November 11, 2020 21:29
This was referenced Nov 12, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@jlesquembre jlesquembre Awaiting requested review from jlesquembre

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bennyandresen @timokau