Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archiver: 3.3.0 -> 3.3.2 [20.09] #102860

Merged
merged 2 commits into from Nov 5, 2020
Merged

archiver: 3.3.0 -> 3.3.2 [20.09] #102860

merged 2 commits into from Nov 5, 2020

Conversation

redvers
Copy link
Member

@redvers redvers commented Nov 5, 2020

Motivation for this change

Issue# #90750 - CVE-2019-10743

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit November 5, 2020 05:07
@mweinelt
Copy link
Member

mweinelt commented Nov 5, 2020

Result of nixpkgs-review pr 102860 1

1 package built:
  • archiver

@mweinelt mweinelt merged commit cfe0a7b into NixOS:release-20.09 Nov 5, 2020
@mweinelt
Copy link
Member

mweinelt commented Nov 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@redvers @mweinelt @marsam