Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mercury: 20.06 -> 20.06.1 #102848

Merged
merged 1 commit into from Nov 7, 2020
Merged

mercury: 20.06 -> 20.06.1 #102848

merged 1 commit into from Nov 7, 2020

Conversation

toothbrush
Copy link
Contributor

Motivation for this change

Update to latest stable release of Mercury, released this week: http://dl.mercurylang.org/release/release-notes-20.06.1.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@toothbrush
Copy link
Contributor Author

So i'm quite a newbie at NixOS in general, i'm not sure what to do besides testing with nix-build -A mercury. I'm currently on NixOS 20.09 and it'd be great if this upgrade could be applied there too, but i'm not certain if that's appropriate. I guess i would follow the instructions in https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md and create a patch on the release branch, too? I'm not sure.

Thanks!

@SuperSandro2000
Copy link
Member

When this is merged you can follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes to backport it.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102848 run on x86_64-linux 1

2 packages built:
  • mercury
  • notmuch-bower

@toothbrush
Copy link
Contributor Author

Hey so now that the tests seem to have passed, what's the path forward to merging? Should i tag anyone in particular? Thanks!

@SuperSandro2000
Copy link
Member

If the package had some maintainers they would have been pinged. Some specific parts of the code also ping people but that does not apply here, too. Lets wait a couple of days and then I could ping someone.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102848 run on x86_64-darwin 1

1 package built:
  • mercury

danieldk
danieldk approved these changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@danieldk danieldk merged commit e6d597a into NixOS:master Nov 7, 2020
@toothbrush toothbrush mentioned this pull request Nov 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@toothbrush @SuperSandro2000 @danieldk @Janik-Haag