Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lean: build olean files #102774

Merged
merged 1 commit into from Nov 4, 2020
Merged

lean: build olean files #102774

merged 1 commit into from Nov 4, 2020

Conversation

gebner
Copy link
Member

@gebner gebner commented Nov 4, 2020

Motivation for this change

Fixes #102647. Thanks to @vvs- for the fix!

I have no idea when or how this broke.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner gebner added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 4, 2020
@ofborg ofborg bot requested a review from thoughtpolice November 4, 2020 15:51
@gebner gebner merged commit 0aaf9d6 into NixOS:master Nov 4, 2020
@gebner
Copy link
Member Author

gebner commented Nov 4, 2020

Backported as ec5a542

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lean] incomplete derivation
2 participants