Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eureka-editor: mark broken on darwin #102775

Merged
merged 1 commit into from Nov 26, 2020
Merged

eureka-editor: mark broken on darwin #102775

merged 1 commit into from Nov 26, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
src/main.cc:55:10: fatal error: 'OSXCalls.h' file not found
#include "OSXCalls.h"
         ^~~~~~~~~~~~
5 warnings and 1 error generated.
make: *** [Makefile:120: obj_linux/main.o] Error 1
make: *** Waiting for unfinished jobs....

#95675 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@OPNA2608
Copy link
Contributor

OPNA2608 commented Nov 5, 2020

broken = stdenv.hostPlatform.isDarwin seems better to me, see Nixpkgs manual:

The difference between a package being unsupported on some system and being broken is admittedly a bit fuzzy. If a program ought to work on a certain platform, but doesn't, the platform should be included in meta.platforms, but marked as broken with e.g. meta.broken = !hostPlatform.isWindows.

It should work on Darwin: The source code has an osx directory for Darwin-specific code / build instructions and the website offers a DMG file to install a precompiled app bundle for macOS users.

I'm checking the source code of the latest git revision and it looks like Makefile unlike CMakeLists.txt never touches the osx directory that contains the missing OSXCalls.h file. A package update & move to CMake might be worth a try if you want to get this running on Darwin?

@SuperSandro2000
Copy link
Member Author

My goal is not to debug this package until it works on Darwin but to reduce random build failures while reviewing updates that are not related to those packages.

@alyssais
Copy link
Member

alyssais commented Nov 9, 2020

Commit message needs an update

@SuperSandro2000 SuperSandro2000 changed the title eureka-editor: set platforms to linux eureka-editor: mark broke on darwin Nov 10, 2020
@SuperSandro2000
Copy link
Member Author

Commit and title updated.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 10, 2020
@SuperSandro2000 SuperSandro2000 changed the title eureka-editor: mark broke on darwin eureka-editor: mark broken on darwin Nov 22, 2020
@SuperSandro2000 SuperSandro2000 merged commit af6ebad into NixOS:master Nov 26, 2020
@SuperSandro2000 SuperSandro2000 deleted the patch-3 branch November 26, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @OPNA2608 @alyssais