Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfsUnstable: 2.0.0-rc4 -> 2.0.0-rc5 #102813

Merged
merged 1 commit into from Nov 5, 2020
Merged

zfsUnstable: 2.0.0-rc4 -> 2.0.0-rc5 #102813

merged 1 commit into from Nov 5, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 4, 2020 •
edited

Motivation for this change

latest zfsUnstable release

https://github.com/openzfs/zfs/releases/tag/zfs-2.0.0-rc5

some linux 5.10 support, and other bug fixes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg test zfs.unstable

@jonringer
Copy link
Contributor Author

builds were already failing in master

https://github.com/NixOS/nixpkgs/pull/102813
2 packages failed to build:
linuxPackages_latest_hardened.zfsUnstable linuxPackages_latest_xen_dom0_hardened.zfsUnstable

16 packages built:
linuxPackages-libre.zfsUnstable linuxPackages.zfsUnstable linuxPackages_4_14.zfsUnstable linuxPackages_4_19.zfsUnstable linuxPackages_4_4.zfsUnstable linuxPackages_4_9.zfsUnstable linuxPackages_5_8.zfsUnstable linuxPackages_5_9.zfsUnstable linuxPackages_hardened.zfsUnstable linuxPackages_latest-libre.zfsUnstable linuxPackages_latest_xen_dom0.zfsUnstable linuxPackages_testing_bcachefs.zfsUnstable linuxPackages_xen_dom0.zfsUnstable linuxPackages_xen_dom0_hardened.zfsUnstable linuxPackages_zen.zfsUnstable zfsUnstable

@hmenke hmenke mentioned this pull request Nov 5, 2020
Closed
10 tasks
@hmenke
Copy link
Member

hmenke commented Nov 5, 2020

Result of nixpkgs-review pr 102813 1

2 packages marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.zfsUnstable
  • linuxPackages_hardkernel_latest.zfsUnstable
2 packages failed to build:
  • linuxPackages_latest_hardened.zfsUnstable
  • linuxPackages_latest_xen_dom0_hardened.zfsUnstable
16 packages built:
  • linuxPackages-libre.zfsUnstable
  • linuxPackages.zfsUnstable (linuxPackages_5_4.zfsUnstable)
  • linuxPackages_4_14.zfsUnstable
  • linuxPackages_4_19.zfsUnstable
  • linuxPackages_4_4.zfsUnstable
  • linuxPackages_4_9.zfsUnstable
  • linuxPackages_5_8.zfsUnstable
  • linuxPackages_5_9.zfsUnstable (linuxPackages_latest.zfsUnstable)
  • linuxPackages_hardened.zfsUnstable
  • linuxPackages_latest-libre.zfsUnstable
  • linuxPackages_latest_xen_dom0.zfsUnstable
  • linuxPackages_testing_bcachefs.zfsUnstable
  • linuxPackages_xen_dom0.zfsUnstable
  • linuxPackages_xen_dom0_hardened.zfsUnstable
  • linuxPackages_zen.zfsUnstable
  • zfsUnstable

@jonringer jonringer merged commit 5d9ea37 into NixOS:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmenke hmenke hmenke approved these changes

@Luflosi Luflosi Luflosi approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @hmenke @Luflosi