Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polkadot: 0.8.25 -> 0.8.26 #102812

Merged
merged 1 commit into from Nov 5, 2020
Merged

polkadot: 0.8.25 -> 0.8.26 #102812

merged 1 commit into from Nov 5, 2020

Conversation

andresilva
Copy link
Member

@andresilva andresilva commented Nov 4, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

andresilva
andresilva commented Nov 4, 2020
View reviewed changes
pkgs/applications/blockchains/polkadot/default.nix
};

cargoSha256 = "08yfafrspkd1g1mhlfwngbknkxjkyymbcga8n2rdsk7mz0hm0vgy";

cargoPatches = [ ./substrate-wasm-builder-runner.patch ];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed since we updated the version of substrate-wasm-builder-runner on the polkadot repo.

@ofborg ofborg bot requested a review from akru November 4, 2020 17:59
@mmahut
Copy link
Member

mmahut commented Nov 5, 2020

Thank you, looks good.

@mmahut mmahut merged commit a06d618 into NixOS:master Nov 5, 2020
@andresilva
Copy link
Member Author

@mmahut The mismatch was a legit one, I was just about to push the fix when this got merged.

@andresilva
Copy link
Member Author

@mmahut #102912 works for me under nixpkgs-review. I'm not really sure what happened there as I'm able to still build the package with both cargoSha256 values. I suppose there is something cached locally on my machine that enables this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@akru akru Awaiting requested review from akru

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andresilva @mmahut @SuperSandro2000