Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxima: 5.42.2 -> 5.44.0 #102861

Merged
merged 2 commits into from Nov 9, 2020
Merged

maxima: 5.42.2 -> 5.44.0 #102861

merged 2 commits into from Nov 9, 2020

Conversation

omasanori
Copy link
Contributor

Motivation for this change

This change updates Maxima to the latest release. The change logs for 5.43 and 5.44 are available.

$ nix path-info -S nixpkgs#maxima
/nix/store/n3j4fqwypjayckkkjvc7akw4hilagj41-maxima-5.42.2         275446544
$ nix path-info -S ./result
/nix/store/nf8i698s6dhv0z9dp8aph92rgyd0hbd1-maxima-5.44.0         278350072
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@omasanori omasanori changed the title maxima: 5.42.4 -> 5.44.0 maxima: 5.42.2 -> 5.44.0 Nov 5, 2020
@ofborg ofborg bot requested a review from peti November 5, 2020 06:04
jonringer
jonringer reviewed Nov 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potential regression with sage

https://github.com/NixOS/nixpkgs/pull/102861
2 packages failed to build:
sage sageWithDoc

3 packages built:
maxima maxima-ecl wxmaxima

cc @timokau

@timokau
Copy link
Member

timokau commented Nov 6, 2020 •
edited

Sage has unfortunately been broken on master for a while (context: #70474 (comment), #70474 (comment)). @omasanori is currently working on fixing it up, so they have probably taken the implications on sage into account.

veprbl
veprbl approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64-darwin

@omasanori
Copy link
Contributor Author

potential regression with sage

@omasanori is currently working on fixing it up, so they have probably taken the implications on sage into account.

Yes, 5.44.0 is the bundled version with the latest (to-be-packaged-in-nixpkgs) SageMath.

@omasanori
Use substituteInPlace as per comment by veprbl.
34e6305 
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@omasanori
Copy link
Contributor Author

Addressed to @veprbl's comment.

@veprbl veprbl merged commit 88de0d7 into NixOS:master Nov 9, 2020
@omasanori omasanori deleted the maxima/update-5.44.0 branch November 9, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@peti peti Awaiting requested review from peti

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@omasanori @timokau @veprbl @jonringer