Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadowsocks-rust: 1.8.18 -> 1.8.23 #102856

Merged
merged 1 commit into from Nov 5, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp
Copy link
Member

stigtsp commented Nov 5, 2020

Tested OK with curl --socks5 on linux x64

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102856 1

1 package built:
  • shadowsocks-rust

@stigtsp stigtsp merged commit 4a72c7e into NixOS:master Nov 5, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102856 run on x86_64-linux 1

1 package built:
  • shadowsocks-rust

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 7, 2020

Result of nixpkgs-review pr 102856 run on x86_64-darwin 1

1 package failed to build:
  • shadowsocks-rust
running 17 tests
test crypto::aead::test::increase_nonce_32_le ... ok
test crypto::aead::test::increase_nonce_64_le ... ok
test crypto::aead::test::increase_nonce_classic_le ... ok
test crypto::cipher::test_cipher::classic_bytes_to_key ... ok
test crypto::cipher::test_cipher::rc4_md5_key_iv ... ok
test crypto::ring::test::test_ring_aes128gcm ... ok
test crypto::ring::test::test_ring_aes256gcm ... ok
test crypto::ring::test::test_ring_chacha20poly1305 ... ok
test crypto::sodium::test::test_rust_crypto_cipher_chacha20 ... ok
test crypto::sodium::test::test_rust_crypto_cipher_chacha20_ietf ... ok
test crypto::sodium::test::test_rust_crypto_cipher_salsa20 ... ok
test crypto::sodium::test::test_rust_crypto_cipher_xchacha20_ietf_poly1305 ... ok
test crypto::sodium::test::test_rust_crypto_cipher_xsalsa20 ... ok
test plugin::test::generate_random_port ... FAILED
test crypto::rc4_md5::test::test_rc4_md5_cipher ... ok
test crypto::cipher::test_cipher::get_cipher ... ok
test crypto::table::test_table_cipher ... ok

failures:

---- plugin::test::generate_random_port stdout ----
thread 'plugin::test::generate_random_port' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 1, kind: PermissionDenied, message: "Operation not permitted" }', src/plugin/mod.rs:316:37
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    plugin::test::generate_random_port

test result: FAILED. 16 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--lib'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants