Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-lfs: 2.12.0 -> 2.12.1 #102857

Merged
merged 1 commit into from Nov 5, 2020
Merged

git-lfs: 2.12.0 -> 2.12.1 #102857

merged 1 commit into from Nov 5, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 5, 2020

Motivation for this change

https://github.com/git-lfs/git-lfs/releases/tag/v2.12.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

vikanezrimaya
vikanezrimaya approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@vikanezrimaya vikanezrimaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Built on x86_64-linux, currently checking if it builds on aarch64-linux

@mweinelt
Copy link
Member

mweinelt commented Nov 5, 2020 •
edited

Fixes CVE-2020-27955 (RCE, Clone to Pwn)

https://www.openwall.com/lists/oss-security/2020/11/05/1

@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 5, 2020
@mweinelt
Copy link
Member

mweinelt commented Nov 5, 2020

LGTM. Built on x86_64-linux, currently checking if it builds on aarch64-linux

# file /nix/store/bd8vxj6143439y3djbafrmc31j43d24b-git-lfs-2.12.1/bin/git-lfs
/nix/store/bd8vxj6143439y3djbafrmc31j43d24b-git-lfs-2.12.1/bin/git-lfs: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /nix/store/by6x4sx9l8i5isvjyicfrbmcpyb1gj9s-glibc-2.32/lib/ld-linux-aarch64.so.1, Go BuildID=Bjo0VgI-SNEKuUPg34dg/vJEpXXYPp03H28uqMyQ3/bKMvV4d9n945KD7LI35Q/FwhFTwqhv5F1XmqVhqsN, stripped

LGTM.

@mweinelt mweinelt merged commit 51f2519 into NixOS:master Nov 5, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102857 run on x86_64-darwin 1

1 package built:
  • git-lfs

@mweinelt
Copy link
Member

mweinelt commented Nov 7, 2020

@marsam Can you take care of backporting this?

@marsam
Copy link
Contributor Author

marsam commented Nov 7, 2020

Sure. backported to 20.09 in 95bb108

@marsam marsam deleted the update-git-lfs branch November 7, 2020 21:45
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@vikanezrimaya vikanezrimaya vikanezrimaya approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marsam @mweinelt @SuperSandro2000 @vikanezrimaya @erictapen